Fix regression for expansion of subcollection on a resource #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label gaprindashvili/yes |
imtayadeway
approved these changes
Jan 5, 2018
|
I think it's 4467c954 |
|
@abellotti yeah, that's it. There were no relevant tests so I guess it was missed |
|
LGTM!! minor change needed in tests & rebase for the travis failure. Thanks @jntullo for fixing this 👍 |
…or a resource even when it is configured to be returned within the api.yml. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1529299
|
Checked commit jntullo@742c182 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
abellotti
approved these changes
Jan 5, 2018
simaishi
pushed a commit
that referenced
this pull request
Jan 5, 2018
Fix regression for expansion of subcollection on a resource (cherry picked from commit 15206e1) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531706
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression where subcollections are not being returned for a resource even when it is configured to be returned within the api.yml via the
:showoption. Two tests were added to ensure the regression does not return.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1529299
@miq-bot add_label blocker, bug