Return correct subcollection actions #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, sub collection actions that are specified on a specific collection (i.e., :generic_object_subcollection_actions: specified on :services: collection) are not taking precedence to those sub collection actions defined on the collection itself (i.e. :subcollection_actions: defined under :generic_objects:). This is causing incorrect actions to be returned, causing the users to believe that they have actions that they do not, such as :create: for the generic objects sub collection on services. https://bugzilla.redhat.com/show_bug.cgi?id=1518833
|
Checked commit jntullo@7b13b36 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
abellotti
approved these changes
Dec 11, 2017
|
👍 @jntullo Thanks for fixing this. |
simaishi
pushed a commit
that referenced
this pull request
Dec 12, 2017
Return correct subcollection actions (cherry picked from commit d5cd683) https://bugzilla.redhat.com/show_bug.cgi?id=1525049
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, sub collection actions that are specified on a specific collection (i.e.,
:generic_object_subcollection_actions:specified on:services:collection) are not taking precedence to those sub collection actions defined on the collection itself (i.e.:subcollection_actions:defined under:generic_objects:). This is causing incorrect actions to be returned, causing the users to believe that they have actions that they do not, such as :create: for the generic objects sub collection on services.This is a reminder to myself that I should probably get around to fixing up #119 ( new year's resolution 😉 )
https://bugzilla.redhat.com/show_bug.cgi?id=1518833
@miq-bot add_label bug, blocker, gaprindashvili/yes