Validate section values for adding new custom attributes via the API #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently validation only occurs for providers, but should be consistent throughout. https://bugzilla.redhat.com/show_bug.cgi?id=1516762
|
@jntullo Cannot apply the following label because they are not recognized: gaprindsahvili/yes |
|
Checked commit jntullo@47010ce with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
imtayadeway
approved these changes
Dec 11, 2017
simaishi
pushed a commit
that referenced
this pull request
Dec 12, 2017
Validate section values for adding new custom attributes via the API (cherry picked from commit 9563b42) https://bugzilla.redhat.com/show_bug.cgi?id=1525047
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom Attributes have restrictions for the sections that are allowed to be added via the API. Currently validation only occurs for providers, but should be consistent throughout for other types. This change essentially updates the code to remove it from providers and make it accessible to all new custom attribute types.
@miq-bot add_label bug, blocker, gaprindsahvili/yes
https://bugzilla.redhat.com/show_bug.cgi?id=1516762