Add subresource_action_identifier spec helper #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current subcollection_action_identifier does not account for subresource actions, which meant that the subresource action could not have a different identifier than the subcollection action. This adds in a new subresource_action_identifier which takes into account both subresource actions defined on the type and on the subtype. This will now allow the orchestration template sub collection actions to be identified properly. Also adjusts a snapshots spec to ensure that the helper works for both cases of identifiers.
|
Checked commit jntullo@718202b with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Looks good. Thanks @jntullo for fixing this 👍 |
abellotti
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
subcollection_action_identifierspec helper does not account for subresource actions, which means that the subresource action cannot not be tested if they have a different identifier than the subcollection action. This adds in a newsubresource_action_identifierwhich takes into account both subresource actions defined on the type and on the subtype. This will now allow theorchestration_templatesub collection actions to be identified properly. This also adjusts a snapshots spec to ensure that the helper works for both cases of identifiers (on the type and subtype)Follow up to #196
@miq-bot assign @abellotti