Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes final .first from custom action specs #216

Merged
merged 1 commit into from
Nov 18, 2017
Merged

Removes final .first from custom action specs #216

merged 1 commit into from
Nov 18, 2017

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Nov 18, 2017 •
edited
Loading

Missed one from #215. Removes .first from specs to make tests a bit more stupid-proof

@d-m-u
Copy link
Contributor Author

d-m-u commented Nov 18, 2017

@miq-bot assign @abellotti

@d-m-u
Copy link
Contributor Author

d-m-u commented Nov 18, 2017

Sorry @abellotti! Missed one.

@d-m-u
Copy link
Contributor Author

d-m-u commented Nov 18, 2017

@miq-bot add_label gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Nov 18, 2017

Checked commit d-m-u@0f48110 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@abellotti
Copy link
Member

Thanks @d-m-u for catching that. 👍

@abellotti abellotti merged commit e52dad9 into ManageIQ:master Nov 18, 2017
@abellotti abellotti added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 18, 2017
simaishi pushed a commit that referenced this pull request Nov 20, 2017
@abellotti @simaishi
Merge pull request #216 from d-m-u/fixing_idiot_tests_3
1690bcd 
Removes final .first from custom action specs
(cherry picked from commit e52dad9)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 1690bcd4cbc81a138969a36a352de7966c0fc5ef
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date:   Fri Nov 17 22:03:04 2017 -0500

    Merge pull request #216 from d-m-u/fixing_idiot_tests_3
    
    Removes final .first from custom action specs
    (cherry picked from commit e52dad99759bfb94d0f709c67cce9641b8bf73ff)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abellotti abellotti abellotti approved these changes

Assignees

@abellotti abellotti

Labels
enhancement gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-m-u @miq-bot @abellotti @simaishi