Add deep symbolization to CustomButton visibility field
#206
Conversation
|
This fix is required for ManageIQ/manageiq-ui-classic#2569 and ManageIQ/manageiq-ui-classic#2636 |
|
/cc @abellotti |
|
Thanks @AparnaKarve this is fine, is this needed for gaprindashvili or just master ? |
|
@abellotti This is needed for gaprindashvili |
spec/requests/custom_buttons_spec.rb
Outdated
| expect(response).to have_http_status(:ok) | ||
| expect(response.parsed_body).to include(expected) | ||
| expect(custom_button.visibility[:roles]).to eq(['_ALL_']) |
There was a problem hiding this comment.
would prefer that we check the custom_button we have to start with, maybe just expect(cb.reload.visibility[:roles]).to ....
There was a problem hiding this comment.
I have addressed this in the last commit (5cb4355)
There was a problem hiding this comment.
commit revised further - 6d268dc
5cb4355 to
6d268dc
Compare
|
Thanks @AparnaKarve for the update 👍 will merge when 🍏 |
6d268dc to
bdf948d
Compare
|
Checked commits AparnaKarve/manageiq-api@81a4fca~...bdf948d with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@abellotti Thank you! |
…b_visibility Add deep symbolization to CustomButton `visibility` field (cherry picked from commit 85c9383)
|
Gaprindashvili backport details: |
The backend expects the
CustomButtonvisibilityfield to be deep symbolized in order to perform Custom Button related operations.Hence appropriate adjustment had to be made in the API as well.