Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom_actions support for /api/cloud_networks #200

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

abellotti
Copy link
Member

@abellotti abellotti commented Nov 10, 2017

Adding custom_actions support for /api/cloud_networks

  • Added missing resource actions
  • Added custom_actions collection option
  • Fixed up role identifier for cloud_networks

@miq-bot
Copy link
Member

miq-bot commented Nov 17, 2017

This pull request is not mergeable. Please rebase and repush.

- Added missing resource actions
- Added custom_actions collection option
- Fixed up role identifier for cloud_networks
@abellotti abellotti force-pushed the cloud_networks_custom_actions branch from a620510 to 0345f8f Compare November 21, 2017 00:25
@abellotti abellotti changed the title [WIP] Adding custom_actions support for /api/cloud_networks Adding custom_actions support for /api/cloud_networks Nov 21, 2017
@abellotti abellotti removed the wip label Nov 21, 2017
@miq-bot
Copy link
Member

miq-bot commented Nov 21, 2017

Checked commit abellotti@0345f8f with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@abellotti
Copy link
Member Author

ping @jntullo

Copy link

@jntullo jntullo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gtanzillo gtanzillo added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 21, 2017
@gtanzillo gtanzillo merged commit 1802902 into ManageIQ:master Nov 21, 2017
@abellotti abellotti deleted the cloud_networks_custom_actions branch November 22, 2017 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants