Fix coercing of string to 0 in parse_id

[jntullo]

Currently, parse_id returns a 0 if a string is passed in, rather than a hash. This checks to ensure the resource passed in is a hash and returns nil otherwise, allowing normal error handling to proceed.

I couldn't find a better place for the test, seems like it doesn't quite belong there and is more of a general case. Thoughts?

@miq-bot add_label bug, gaprindashvili/yes

[miq-bot]

Checked commit jntullo@7bd90ca with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 3 offenses detected

spec/requests/services_spec.rb

• ❗ - Line 1085, Col 52 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 1086, Col 52 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 1086, Col 72 - Style/SpaceBeforeComma - Space found before comma.

[chrisarcand]

I couldn't find a better place for the test, seems like it doesn't quite belong there and is more of a general case. Thoughts?

I think adding tests for specific bugs that happen to test general cases is fine; it's covered somewhere :)

LGTM

[chrisarcand]

You don't need resource.blank? anymore, though it's fine that it short circuits the case below.

[abellotti]

Thanks @jntullo for fixing this 👍

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit fbe9f2164f84634695ae26aa4d8d1aebcd63a3e7
Author: Chris Arcand <chrisarcand@users.noreply.github.com>
Date:   Thu Nov 2 10:45:11 2017 -0500

    Merge pull request #173 from jntullo/bug/fix_coerced_zero
    
    Fix coercing of string to 0 in parse_id
    (cherry picked from commit 42813a23b65b485609033cbaa8d65041549b2e6b)