Generic Object Definition CRUD

[jntullo]

manageiq-api version of ManageIQ/manageiq#15374

This PR adds:

GET /api/generic_object_definitions/
GET /api/generic_object_definitions/:id
GET /api/generic_object_definitions/:name

DELETE /api/generic_object_definitions/:id
DELETE /api/generic_object_definitions/:name
POST /api/generic_object_definitions/:id      action: "delete"
POST /api/generic_object_definitions/:name    action: "delete"
POST /api/generic_object_definitions          action: "delete" (works with name, id, href)

POST /api/generic_object_definitions

POST /api/generic_object_definitions/:id      action: "edit"
POST /api/generic_object_definitions/:name    action: "edit"
POST /api/generic_object_definitions          action: "edit" (works with name, id, href)

Example of create:

POST /api/generic_object_definitions
{
  "name"        : "LoadBalancer",
  "description" : "LoadBalancer description",
  "properties"  : {
    "attributes"   : {
      "address"      : "string",
      "last_restart" : "datetime"
    },
    "associations" : {
      "vms"      : "Vm",
      "services" : "Service"
    },
    "methods"      : [
      "add_vm",
      "remove_vm"
    ]
  }
}

Editing a generic object definition. Properties will be updated as is - IE if you remove "methods" as in the below example, properties will no longer have methods and contain the attributes and associations passed in.

POST /api/generic_object_definitions/:id
{
 "action"       : "edit",
  "name"        : "LoadBalancer",
  "description" : "LoadBalancer description",
  "properties"  : {
    "attributes"   : {
      "address"      : "string",
      "last_restart" : "datetime"
    },
    "associations" : {
      "vms"      : "Vm",
      "services" : "Service"
    }
  }
}

@miq-bot add_label enhancement, wip
@miq-bot assign @abellotti

[jntullo]

Disabling as I prefer that the sample requests not use word arrays to better align with how the request will look.

[jntullo]

@miq-bot remove_label wip

[imtayadeway]

Does expand=resources do the right thing? Could we add a test for that?

[imtayadeway]

Also, tiny nit, but can you group all the verification code together and separately from the execution step(s)? 🍨

[abellotti]

If you can in the PR comments, create and update examples with sample data showing the properties, methods, etc. Thanks!!

[abellotti]

Looks good @jntullo, minor updates noted. Thanks!!

[abellotti]

Let's add Rbac.filtered_object before returning it.

[abellotti]

Let's leverage ApplicationRecord.compressed_id?(id) and leverage resource_search for id based.

[abellotti]

we probably want logic separation, i.e. check if id is compressed_id? to do a klass.find otherwise do the find_by :name, (just in case someone named one as a numeric string).

[miq-bot]

Checked commits jntullo/manageiq-api@55db55e~...25b9576 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks fine. ⭐

[abellotti]

Thanks @jntullo for this enhancement, LGTM!!. 😍