Skip to content

Commit

Permalink
Removing bulk query support for container_images
Browse files Browse the repository at this point in the history
- API does not currently support guid as virtual attributes
  • Loading branch information
abellotti committed Nov 20, 2017
1 parent da4f8f7 commit 7abbc74
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 11 deletions.
3 changes: 0 additions & 3 deletions config/api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -703,9 +703,6 @@
:get:
- :name: read
:identifier: container_image_show_list
:post:
- :name: query
:identifier: container_image_show_list
:resource_actions:
:get:
- :name: read
Expand Down
5 changes: 0 additions & 5 deletions spec/requests/collections_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -406,11 +406,6 @@ def test_collection_bulk_query(collection, collection_url, klass, id = nil)
test_collection_bulk_query(:container_deployments, api_container_deployments_url, ContainerDeployment)
end

it "bulk query ContainerImages" do
FactoryGirl.create(:container_image)
test_collection_bulk_query(:container_images, api_container_images_url, ContainerImage)
end

it "bulk query Data Stores" do
FactoryGirl.create(:storage)
test_collection_bulk_query(:data_stores, api_data_stores_url, Storage)
Expand Down
6 changes: 3 additions & 3 deletions spec/requests/custom_actions_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ def define_custom_button1(resource)
describe "Container Image" do
before(:each) do
@resource = FactoryGirl.create(:container_image)
@button1 = define_custom_button1(@resource)
@button = define_custom_button1(@resource)
end

it "queries return custom actions defined" do
Expand All @@ -371,14 +371,14 @@ def define_custom_button1(resource)
expect(response.parsed_body).to include(
"id" => @resource.id.to_s,
"href" => api_container_image_url(nil, @resource),
"actions" => a_collection_including(a_hash_including("name" => @button1.name))
"actions" => a_collection_including(a_hash_including("name" => @button.name))
)
end

it "accept custom actions" do
api_basic_authorize

post api_container_image_url(nil, @resource), :params => gen_request(:button1, "key1" => "value1")
post api_container_image_url(nil, @resource), :params => gen_request(@button.name, "key1" => "value1")

expect_single_action_result(:success => true, :message => /.*/, :href => api_container_image_url(nil, @resource))
end
Expand Down

0 comments on commit 7abbc74

Please sign in to comment.