Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve query used when fetching collection actions #77

Merged

Conversation

abellotti
Copy link
Member

Enhancement to improve the query performed when the actions the collection need to be fetched.

@abellotti abellotti requested a review from gtanzillo February 20, 2018 14:49
@abellotti abellotti requested review from chessbyte and removed request for chessbyte February 20, 2018 14:53
@abellotti
Copy link
Member Author

/cc @bdunne

I will create another PR to support the faraday timeout's.

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I don't have merge rights, but LGTM

@gtanzillo gtanzillo merged commit d293d48 into ManageIQ:master Feb 20, 2018
bdunne added a commit that referenced this pull request Mar 14, 2018
- Changed
  - Adding support for Faraday's open_timeout and timeout options
    [[#78](#78)]
  - Loosen dependency on activesupport
    [[#74](#74)]
  - Updated JSON gem to 2.1.0
    [[#73](#73)]
  - Loosen dependency on faraday to allow for upgrades
    [[#71](#71)]
  - Enhanced ServerInfo to support the new \_href entries
    [[#66](#66)]

- Fixed
  - Improve query used when fetching collection actions
    [[#77](#77)]
abellotti added a commit to abellotti/manageiq-api-client that referenced this pull request Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants