-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve query used when fetching collection actions #77
Merged
gtanzillo
merged 1 commit into
ManageIQ:master
from
abellotti:improved_query_for_fetching_actions
Feb 20, 2018
Merged
Improve query used when fetching collection actions #77
gtanzillo
merged 1 commit into
ManageIQ:master
from
abellotti:improved_query_for_fetching_actions
Feb 20, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on the collection need to be fetched.
/cc @bdunne I will create another PR to support the faraday timeout's. |
gtanzillo
approved these changes
Feb 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good!
bdunne
approved these changes
Feb 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I don't have merge rights, but LGTM
bdunne
added a commit
that referenced
this pull request
Mar 14, 2018
- Changed - Adding support for Faraday's open_timeout and timeout options [[#78](#78)] - Loosen dependency on activesupport [[#74](#74)] - Updated JSON gem to 2.1.0 [[#73](#73)] - Loosen dependency on faraday to allow for upgrades [[#71](#71)] - Enhanced ServerInfo to support the new \_href entries [[#66](#66)] - Fixed - Improve query used when fetching collection actions [[#77](#77)]
gtanzillo
added a commit
to gtanzillo/manageiq
that referenced
this pull request
Mar 20, 2018
gtanzillo
added a commit
to gtanzillo/manageiq
that referenced
this pull request
Mar 20, 2018
JakubKubista
pushed a commit
to JakubKubista/manageiq
that referenced
this pull request
Mar 29, 2018
abellotti
added a commit
to abellotti/manageiq-api-client
that referenced
this pull request
Apr 2, 2018
JakubKubista
pushed a commit
to JakubKubista/manageiq
that referenced
this pull request
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement to improve the query performed when the actions the collection need to be fetched.