Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf #2391 and #812
After I added locks for font handles in JuliaGraphics/FreeTypeAbstraction.jl#87 I also add a few locks around font handling in CairoMakie. With that I don't get crashes anymore for this code:
For some reason I sometimes get hangs if I create the plots in threads as well, but that's not an issue from this PR which is only concerned with the rendering part. On an M1 macbook with 10 threads I get
3.109981 seconds (438.09 k allocations: 434.883 MiB, 0.85% gc time)
for the example above without threads, and0.437824 seconds (439.49 k allocations: 435.019 MiB)
with threads enabled, which would be a speedup factor of 7.1.