Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depwarn for cairomakie lines #3200

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Conversation

SimonDanisch
Copy link
Member

CairoMakie was double converting the linestyle (@get_attribute already applies attribute_conversion), so it was running into the depwarn for any linestyle...

@MakieBot
Copy link
Collaborator

MakieBot commented Sep 1, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 11.92s (11.82, 12.04) 0.07+- 1.16s (1.13, 1.18) 0.02+- 706.54ms (689.12, 753.16) 21.23+- 10.82ms (10.68, 10.98) 0.11+- 137.62ms (136.93, 138.91) 0.69+-
master 11.94s (11.88, 12.11) 0.08+- 1.17s (1.16, 1.18) 0.01+- 696.32ms (685.19, 706.58) 6.59+- 10.78ms (10.64, 11.02) 0.12+- 137.28ms (136.34, 138.21) 0.84+-
evaluation -0.17%, -0.02s invariant (-0.27d, 0.63p, 0.08std) -1.24%, -0.01s invariant (-1.08d, 0.08p, 0.01std) +1.45%, 10.22ms invariant (0.65d, 0.26p, 13.91std) +0.38%, 0.04ms invariant (0.36d, 0.51p, 0.11std) +0.25%, 0.34ms invariant (0.45d, 0.42p, 0.76std)
CairoMakie 14.82s (12.76, 16.10) 1.05+- 1.54s (1.32, 1.79) 0.14+- 283.53ms (263.49, 311.36) 19.19+- 17.16ms (16.07, 18.07) 0.67+- 9.35ms (8.46, 9.85) 0.45+-
master 14.82s (12.76, 15.84) 1.13+- 1.61s (1.37, 1.83) 0.16+- 333.26ms (268.36, 473.71) 67.96+- 16.77ms (15.92, 18.15) 0.94+- 6.94ms (6.53, 8.04) 0.56+-
evaluation +0.01%, 0.0s invariant (0.00d, 1.00p, 1.09std) -4.47%, -0.07s invariant (-0.45d, 0.42p, 0.15std) -17.54%, -49.73ms noisy🤷‍♀️ (-1.00d, 0.11p, 43.57std) +2.28%, 0.39ms invariant (0.48d, 0.39p, 0.80std) +25.82%, 2.42ms slower❌ (4.78d, 0.00p, 0.50std)
WGLMakie 17.22s (16.40, 18.39) 0.69+- 1.77s (1.69, 1.91) 0.09+- 15.87s (15.35, 16.78) 0.50+- 23.54ms (21.85, 25.12) 1.28+- 1.49s (1.36, 1.63) 0.08+-
master 17.54s (16.51, 19.05) 0.89+- 1.79s (1.69, 1.92) 0.08+- 16.21s (15.20, 17.52) 0.90+- 22.57ms (21.19, 23.52) 0.79+- 1.48s (1.34, 1.62) 0.08+-
evaluation -1.88%, -0.32s invariant (-0.41d, 0.46p, 0.79std) -1.53%, -0.03s invariant (-0.32d, 0.56p, 0.08std) -2.17%, -0.34s invariant (-0.47d, 0.40p, 0.70std) +4.14%, 0.97ms invariant (0.91d, 0.12p, 1.04std) +0.82%, 0.01s invariant (0.15d, 0.79p, 0.08std)

@SimonDanisch SimonDanisch merged commit ac02141 into master Sep 1, 2023
@SimonDanisch SimonDanisch deleted the sd/fix-cairomakie-linestyle branch September 1, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants