-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uvloop strictly needs SO_REUSEPORT #550
Comments
This appears to still be an issue: uvloop version: 0.19.0 |
The code correctly detects whether SO_REUSEPORT is available (look for has_SO_REUSEPORT). Unfortunately, at about line 1778 of uvloop/loop.pyx this code, which is where it's failing:
is incorrect. The use of
A quick test confirms that, with this change, a build on illumos is successful. |
@ptribble would you mind to create a PR to fix the issue? Thanks. |
Changes ======= * Add cleanup_socket param on create_unix_server() (#623) (by @fantix in d6114d2) Fixes ===== * Use cythonized SO_REUSEPORT rather than the unwrapped native one. (#609) (by @ptribble in 4083a94 for #550) * UDP errors should result in protocol.error_received (#601) (by @jensbjorgensen in 3c3bbef) * Updates for Cython3 (#587) (by @alan-brooks in 3fba9fa for #587) * Test with Python 3.13 (#610) (by @edgarrmondragon in fb5a139)
uvloop expects that
SO_REUSEPORT
is supported everywhere. Unfortunately, there are some platforms whereSO_REUSEPORT
is not supported. For example illumos.Error message:
PYTHONASYNCIODEBUG
in env?: N/ACould you please detect the
SO_REUSEPORT
support during build and do not try to useSO_REUSEPORT
if it is not available?Thank you.
The text was updated successfully, but these errors were encountered: