Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from #\20 to #\9 #12

Merged
merged 2 commits into from
May 26, 2017
Merged

Switch from #\20 to #\9 #12

merged 2 commits into from
May 26, 2017

Conversation

valtlai
Copy link
Contributor

@valtlai valtlai commented May 26, 2017 •
edited by MadLittleMods
Loading

Fixes #11

Switch from #\20 to #\9

@valtlai valtlai mentioned this pull request May 26, 2017
Closed
@valtlai valtlai changed the title Switch #\20 to #\9 Switch from #\20 to #\9 May 26, 2017
@iamstarkov
Copy link
Contributor

iamstarkov commented May 26, 2017 •
edited by MadLittleMods
Loading

imho, I don't see strong reasoning behind this.

@valtlai
Copy link
Contributor Author

valtlai commented May 26, 2017

I thought why not use a shorter one and save some bytes. But I understand this has no practical effect.

MadLittleMods
MadLittleMods reviewed May 26, 2017
View reviewed changes
index.js Outdated
// >
// > — https://twitter.com/subzey/status/829050478721896448
stackableRoot: ':not(#' + CSS_ESCAPED_SPACE + ')'
// > — https://twitter.com/subzey/status/829050478721896448 (originally \20)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valtlai Let's remove this Twitter quotation now that things have changed and don't match up as nicely.

MadLittleMods
MadLittleMods requested changes May 26, 2017
View reviewed changes
Copy link
Owner

@MadLittleMods MadLittleMods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Twitter quotation and add an "Upcoming" changelog entry for these changes 😀

@MadLittleMods MadLittleMods merged commit 1e7cc91 into MadLittleMods:master May 26, 2017
@MadLittleMods
Copy link
Owner

Thanks @valtlai 💾 📉 🚀

@MadLittleMods
Copy link
Owner

Published to npm, postcss-increase-specificity@0.5.0 , https://www.npmjs.com/package/postcss-increase-specificity 💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadLittleMods MadLittleMods MadLittleMods requested changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valtlai @iamstarkov @MadLittleMods