Update RealRoots package to version 1.0 to match JSAG #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the RealRoots package so that it (almost) matches the published version in JSAG. This is so we can properly add it to the list of "certified" packages for the forthcoming 1.24.11 release.
The one difference between the proposed version of the package and the JSAG-published version is that the
Headlinewas shortened in #3385.One thing I'm not sure about -- @cel34-bath submitted a couple PR's with updates to this package earlier this year (#3100, #3153). This part of the code (the
realRootsIsolationmethod) was also changed in the version published in JSAG. Does the published version incorporate these changes? Or should they be restored?Cc: @JordyLopez27, @kmaluccio, @FrankSottile, @tjyahl, @cel34-bath