Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment out use of <concepts> header file #3131

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

mikestillman
Copy link
Member

Forgot to comment out this header file for use with <= c++17...

@mahrud
Copy link
Member

mahrud commented Feb 14, 2024

Could you use this instead?

#if __cplusplus >= 202002L
    // C++20 (and later) code
#endif

@mikestillman
Copy link
Member Author

@mahrud @d-torrance We decided to not try to maintain two different c++ versions for the moment. We are already maintaining TBB and no TBB. Actually, now that TBB has settled down, perhaps we can insist on TBB support. Thoughts?

@mahrud
Copy link
Member

mahrud commented Feb 14, 2024

I'm not asking for supporting two different versions. I just don't like the use of #if 0 because it's unclear what it means. Is this code deprecated and should be deleted? Is it experimental and not ready yet? Is it disabled because it's wrong and should be fixed?

I see that you deleted it, which is also fine.

@d-torrance
Copy link
Member

We are already maintaining TBB and no TBB. Actually, now that TBB has settled down, perhaps we can insist on TBB support. Thoughts?

That's fine with me -- the Debian/Ubuntu packages build with TBB support in all cases.

@mahrud
Copy link
Member

mahrud commented Feb 14, 2024

We are already maintaining TBB and no TBB. Actually, now that TBB has settled down, perhaps we can insist on TBB support. Thoughts?

That's fine with me -- the Debian/Ubuntu packages build with TBB support in all cases.

Is it tbb 2020 in all cases though?

@d-torrance
Copy link
Member

Is it tbb 2020 in all cases though?

Yeah. I had to backport TBB 2020 for a couple of the older releases.

@DanGrayson DanGrayson merged commit b96cb9f into Macaulay2:development Feb 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants