Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualResolutions minor update #3129

Merged
merged 10 commits into from
Feb 14, 2024

Conversation

mahrud
Copy link
Member

@mahrud mahrud commented Feb 13, 2024

Quick update that fixes a few issues and adds some speedups.

  • raised the limit of FourTiTwo for printing debug info
  • added quick test for non-quasilinearity in LinearTruncations
  • improved multigradedRegularity
  • added new test for multigradedRegularity
  • quickfix in VirtualResolutions
  • fixed internal function plotRegion

One important change in Core:

  • improved RingMap ** Module for modules without relations (e.g. an image module remain an image module)

@mahrud mahrud force-pushed the VirtualResolutions branch from c33f7aa to 060e16f Compare February 13, 2024 18:19
@mahrud
Copy link
Member Author

mahrud commented Feb 13, 2024

@mikestillman @DanGrayson currently RingMap Module only works for free modules and image modules while RingMap ** Module will convert any module to a cokernel module since it computes cokernel f presentation M.

Is there any reason why both RingMap Module and RingMap ** Module should not work for all modules by just applying the ring map to the generators and relations and creating an equivalent subquotient module?

This PR is changing RingMap ** Module to do as above, and I expected some test to fail if this was on purpose, but it doesn't seem to be the case:

RingMap Ideal := Ideal => (f, I) -> ideal f module I
RingMap Module := Module => (f, M) -> (
(S, R) := (target f, source f);
if R =!= ring M then error "expected module over source ring";
if M.?relations then error "ring map applied to module with relations: use '**' or 'tensor' instead";
if M.?generators then image f M.generators
else ( -- M is a free module
d := degrees M;
e := f.cache.DegreeMap \ d;
-- use the same module if we can
if R === S and d === e then M else S^-e)
)
-- misc
tensor(RingMap, Module) := Module => {} >> opts -> (f, M) -> (
if source f =!= ring M then error "expected module over source ring";
subquotient(f ambient M,
if M.?generators then f M.generators,
if M.?relations then f M.relations))
RingMap ** Module := Module => (f, M) -> tensor(f, M)

@mahrud mahrud force-pushed the VirtualResolutions branch from 691574a to 15b8b3d Compare February 13, 2024 20:50
@mahrud
Copy link
Member Author

mahrud commented Feb 13, 2024

@mikestillman I added a fix for the bug from David's email here.

Otherwise, the following example from Complexes fails:
     S = kk[a..e]
     J = ideal(a^3-e^3, a*b^2-c*e^2, a*b*c, a*b*c + a^3 - e^3)
     C = freeResolution(J, Strategy => 3)
     dd^C_1 == gens J
@DanGrayson DanGrayson merged commit 7e6c592 into Macaulay2:development Feb 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants