-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MPFR support to ForeignFunctions package #3124
Conversation
Returns ffi_type_pointer
Matches the behavior of mpfrT. Main changes: * ffi.d code now expects a sequence of 3 elements, with 0 as the "bits", which simplifies the construction at top level * use moveToZZ so that all the allocated memory will be garbage collected * comments!
I'm a bit confused. Ideally one shouldn't need any changes to the interpreter/engine to connect to a new library using foreign functions, right? Is this just an optimization then? |
Correct. This is so we can call functions from other libraries that might use MPFR. The specific case I have in mind is the ball arithmetic stuff in FLINT. It would be possible to call everything just using |
Fixes compiler warnings about discarding const qualifiers
For example: