Fix code scanning alert #9: Server-side request forgery #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
| url = self.homepage.gsub("github.com/", "api.github.com/repos/") | ||
| url = url[0..-2] if url.end_with?("/") # what is this, 2001? We got to remove the trailing `/` otherwise GitHub will fail | ||
| puts("Fetching #{url}") | ||
| conn = Faraday.new(url: url) do |builder| |
Check failure
Code scanning / CodeQL
Server-side request forgery Critical
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 7 months ago
To fix the SSRF vulnerability, we need to ensure that the URL used in the Faraday.new request is strictly validated against a list of allowed URLs. This can be achieved by enhancing the valid_github_url? method to perform a more thorough validation and ensuring that the URL is fully matched against the ALLOWED_GITHUB_REPOS list.
- Enhance the
valid_github_url?method to perform a full match against the allowed URLs. - Ensure that the URL used in the
Faraday.newrequest is strictly validated.
Suggested changeset
1
fastlane/helper/plugin_scores_helper.rb
| @@ -243,3 +243,3 @@ | ||
| ] | ||
| allowed_urls.any? { |allowed_url| url.start_with?(allowed_url) } | ||
| allowed_urls.include?(url) | ||
| end | ||
| @@ -254,3 +254,3 @@ | ||
| # e.g. https://api.github.com/repos/fastlane/fastlane | ||
| if valid_github_url?(self.homepage) && ALLOWED_GITHUB_REPOS.include?(self.homepage) | ||
| if valid_github_url?(self.homepage) | ||
| url = self.homepage.gsub("github.com/", "api.github.com/repos/") |
Copilot is powered by AI and may make mistakes. Always verify output.
|
|
||
| url += "/stats/contributors" | ||
| puts("Fetching #{url}") | ||
| conn = Faraday.new(url: url) do |builder| |
Check failure
Code scanning / CodeQL
Server-side request forgery Critical
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/MacPaw/fastlane/security/code-scanning/9
Suggested fixes powered by Copilot Autofix. Review carefully before merging.