Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move v2 missions endpoints to REST #497

Merged
merged 1 commit into from
Jan 16, 2025
Merged

refactor: move v2 missions endpoints to REST #497

merged 1 commit into from
Jan 16, 2025

Conversation

lwih
Copy link
Collaborator

@lwih lwih commented Jan 14, 2025

No description provided.

@MTES-MCT MTES-MCT deleted a comment from github-actions bot Jan 15, 2025
@MTES-MCT MTES-MCT deleted a comment from github-actions bot Jan 15, 2025
@github-actions GitHub Actions
Copy link

Coverage Report for frontend

Status Category Percentage Covered / Total
🟢 Lines 59.38% (🎯 40%) 2530 / 4260
🟢 Statements 58.55% (🎯 40%) 2631 / 4493
🟢 Functions 44.88% (🎯 40%) 610 / 1359
🟢 Branches 49.37% (🎯 40%) 1025 / 2076
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
frontend/src/v2/features/common/services/use-mission-action.tsx 16.66% 0% 0% 20% 6-13
frontend/src/v2/features/common/services/use-missions.tsx 11.11% 0% 0% 11.11% 14-33
Generated in workflow #1565 for commit f705587 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link

Overall Project 50.64% -0.04% ❌
Files changed 76.52% ❌

File Coverage
MissionRestController.kt 80.98% -13.17% ❌

xtiannyeto
xtiannyeto approved these changes Jan 16, 2025
View reviewed changes
...src/main/kotlin/fr/gouv/dgampa/rapportnav/infrastructure/api/bff/v2/MissionRestController.kt

// temporarily add fictive missions
val user = getUserFromToken.execute()
val fakeMissions = fakeMissionData.getFakeMissionsforUser(user).map { Mission.fromMissionEntity(it) }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to find a way to remove fake missions, really

@xtiannyeto xtiannyeto merged commit 507c318 into main Jan 16, 2025
9 checks passed
@xtiannyeto xtiannyeto deleted the offline branch January 16, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xtiannyeto xtiannyeto xtiannyeto approved these changes

@aleckvincent aleckvincent Awaiting requested review from aleckvincent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lwih @xtiannyeto