Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(431) Ajout Dialog Creation Mission ULAM (frontend only) #432

Merged
merged 8 commits into from
Dec 17, 2024

Conversation

aleckvincent
Copy link
Collaborator

No description provided.

@aleckvincent aleckvincent linked an issue Nov 14, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Nov 14, 2024

Coverage Report for frontend

Status Category Percentage Covered / Total
🟢 Lines 76.21% (🎯 50%) 1971 / 2586
🟢 Statements 76.1% (🎯 50%) 2051 / 2695
🟢 Functions 73.09% (🎯 50%) 508 / 695
🟢 Branches 68.73% (🎯 50%) 910 / 1324
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
frontend/src/features/common/types/mission-types.ts 100% 100% 100% 100%
Generated in workflow #1396 for commit 0c64866 by the Vitest Coverage Report Action

Copy link

Overall Project 42.63%

There is no coverage information present for the Files changed

Copy link

github-actions bot commented Dec 3, 2024

Overall Project 47.74%

There is no coverage information present for the Files changed

@aleckvincent aleckvincent marked this pull request as ready for review December 4, 2024 16:14
Copy link

github-actions bot commented Dec 4, 2024

Overall Project 47.74%

There is no coverage information present for the Files changed

Copy link

Overall Project 47.74%

There is no coverage information present for the Files changed

reinforcementType?: MissionReinforcementTypeEnum
nbHourAtSea?: number
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composition type MissionULAMGeneralInfoInitialInput = MissionULAMGeneralInfoInitial & { bla, bla, bla....}

DIRM = 'DIRM'
}

export const REPORT_TYPE_OPTIONS = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hook, comme useVessel , tu peux faire un useReinforcement ou useMissionType (centralisé du meme metier)

@@ -61,6 +61,23 @@ export type CompletenessForStats = {
sources?: MissionSourceEnum[]
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2, pas de dépendance entre V2 et V1 met ca plutot dans src/v2/etc...

@@ -0,0 +1,49 @@
import { FieldProps } from 'formik'
import { postprocessDateFromPicker, preprocessDateForPicker } from '@common/components/elements/dates/utils.ts'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utilise useDate: pas de dépendance entre V1 et v2

const { preprocessDateForPicker, postprocessDateFromPicker } = useDate()

import MissionCreateDialog from '../mission-create-dialog.tsx'

describe('MissionCreateDialog', () => {
it('renders the dialog when isOpen is true', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiiiiiiiiiiiiiicccceeeeeeeeeee

<Dialog.Body style={{ backgroundColor: THEME.color.gainsboro }}>
<Stack direction="column" spacing="1.5rem" >
<MissionGeneralInformationUlamFormNew
startDateTimeUtc="2024-01-01T00:00:00Z"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static Date?

<MissionGeneralInformationUlamFormNew
startDateTimeUtc="2024-01-01T00:00:00Z"
endDateTimeUtc="2024-01-01T00:00:00Z"
missionType={[MissionTypeEnum.AIR]}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static Value?

return (
<>
{initValue && (
<Formik initialValues={initValue} onSubmit={handleSubmit}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiiiiiiiiiiiccccccceeeeeeee!!!!!!!!!!

<Formik initialValues={initialValues} onSubmit={handleSubmit}>
<>
<FormikEffect onChange={newValues => handleSubmit(newValues as NewMissionUlamGeneralInfoInitial)} />
<Field name={"missionGeneralInfo"}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiiiceeeeee :)

Copy link

Overall Project 47.74%

There is no coverage information present for the Files changed

Copy link

Overall Project 47.74%

There is no coverage information present for the Files changed

1 similar comment
Copy link

Overall Project 47.74%

There is no coverage information present for the Files changed

@aleckvincent aleckvincent merged commit fdd0350 into main Dec 17, 2024
9 checks passed
@aleckvincent aleckvincent deleted the 431-ajout-modal-creation-de-rapport-ulam branch December 17, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ajout modal creation de rapport ulam
2 participants