-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(431) Ajout Dialog Creation Mission ULAM (frontend only) #432
Conversation
Coverage Report for frontend
File Coverage
|
|
|
|
|
reinforcementType?: MissionReinforcementTypeEnum | ||
nbHourAtSea?: number | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
composition type MissionULAMGeneralInfoInitialInput = MissionULAMGeneralInfoInitial & { bla, bla, bla....}
DIRM = 'DIRM' | ||
} | ||
|
||
export const REPORT_TYPE_OPTIONS = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hook, comme useVessel , tu peux faire un useReinforcement ou useMissionType (centralisé du meme metier)
@@ -61,6 +61,23 @@ export type CompletenessForStats = { | |||
sources?: MissionSourceEnum[] | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v2, pas de dépendance entre V2 et V1 met ca plutot dans src/v2/etc...
@@ -0,0 +1,49 @@ | |||
import { FieldProps } from 'formik' | |||
import { postprocessDateFromPicker, preprocessDateForPicker } from '@common/components/elements/dates/utils.ts' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utilise useDate: pas de dépendance entre V1 et v2
const { preprocessDateForPicker, postprocessDateFromPicker } = useDate()
import MissionCreateDialog from '../mission-create-dialog.tsx' | ||
|
||
describe('MissionCreateDialog', () => { | ||
it('renders the dialog when isOpen is true', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiiiiiiiiiiiiiiicccceeeeeeeeeee
<Dialog.Body style={{ backgroundColor: THEME.color.gainsboro }}> | ||
<Stack direction="column" spacing="1.5rem" > | ||
<MissionGeneralInformationUlamFormNew | ||
startDateTimeUtc="2024-01-01T00:00:00Z" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static Date?
<MissionGeneralInformationUlamFormNew | ||
startDateTimeUtc="2024-01-01T00:00:00Z" | ||
endDateTimeUtc="2024-01-01T00:00:00Z" | ||
missionType={[MissionTypeEnum.AIR]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Static Value?
return ( | ||
<> | ||
{initValue && ( | ||
<Formik initialValues={initValue} onSubmit={handleSubmit}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiiiiiiiiiiiiccccccceeeeeeee!!!!!!!!!!
<Formik initialValues={initialValues} onSubmit={handleSubmit}> | ||
<> | ||
<FormikEffect onChange={newValues => handleSubmit(newValues as NewMissionUlamGeneralInfoInitial)} /> | ||
<Field name={"missionGeneralInfo"}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiiiiceeeeee :)
|
|
1 similar comment
|
No description provided.