Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛(api) return a 403 HTTP status upon authentication failure #17

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

jmaupetit
Copy link
Member

@jmaupetit jmaupetit commented Apr 5, 2024

Purpose

When an ID token expires or is invalid, we should respond with a 403 status and an appropriate error message instead of a 500.

Proposal

  • integrate a custom exception handler for authentication failures
  • tests all possible failures

@jmaupetit jmaupetit force-pushed the fix-authentication-errors branch from 0a939a5 to f599199 Compare April 5, 2024 16:07
@jmaupetit jmaupetit self-assigned this Apr 5, 2024
@jmaupetit jmaupetit force-pushed the fix-authentication-errors branch from a21720f to aac6d3d Compare April 8, 2024 09:37
When an ID token expires or is invalid, we should respond with a 403
status and an appropriate error message instead of a 500.
@jmaupetit jmaupetit force-pushed the fix-authentication-errors branch from aac6d3d to e8de381 Compare April 8, 2024 09:41
@jmaupetit jmaupetit merged commit 66d9a6a into main Apr 8, 2024
8 checks passed
@jmaupetit jmaupetit deleted the fix-authentication-errors branch April 8, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant