fix for subset handling -> display ID updates #137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lingering issue after #135 was that jumping to different cell executions and same-dataset rendering would mix up display IDs.
The simplest solution is to just pop the hash out of the subset cache so the only time we add data is during a resampling event, which means the only time it's going to be checked is immediately after an
update_display_id()
call whenformat()
is being called. Once that update process is done, we pop the hash out, and no follow-on confusion happens.Extra: minor metadata updates to handle subsets pulling parent metadata to include resample filters.