Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISMIP6 Greenland regions #199

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

cbegeman
Copy link
Collaborator

Add regions around the Greenland continental shelf as defined by ISMIP6.

@cbegeman cbegeman requested a review from alexolinhager May 10, 2024 21:51
@cbegeman
Copy link
Collaborator Author

@cbegeman
Copy link
Collaborator Author

@xylar Do you have thoughts on whether the existing ISMIP6 Regions group should have the Greenland ISMIP6 regions added? My inclination was no.

@xylar
Copy link
Collaborator

xylar commented May 11, 2024

@cbegeman, it seems like we could consider renaming the ISMIP6 Regions to ISMIP6 Antarctic Regions. I wouldn't try to have the Antarctic and Greenland regions in the same group.

@xylar
Copy link
Collaborator

xylar commented May 11, 2024

Looking around, the ISMIP6 Regions are only used in 2 places right now. One is just a utility script so not something I feel a strong need to maintain but which would be easy to update:
https://github.com/MPAS-Dev/MPAS-Analysis/blob/e57f81c0474674fac5dbaeb4eecbcb438f42ec84/utility_scripts/make_ismip6_region_masks.py#L14
And the other is in Compass:
https://github.com/MPAS-Dev/compass/blob/74edf148186599dbcfe39f738af4f59bb0782e80/compass/ocean/tests/global_ocean/files_for_e3sm/diagnostic_masks.py#L86

Both of these would be quick to update when you add the Greenland Regions.

Copy link
Contributor

@alexolinhager alexolinhager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbegeman, thank you for putting this all together! Looks great, and no changes to request

@xylar xylar merged commit 430d9ca into MPAS-Dev:main May 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants