Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix files for E3SM following reorg of init #837

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jul 1, 2024

Following #813, the initial state is the same whether ice shelf cavities are present or not. It is the result of the init/initial_state step.

The remap_ice_shelf_melt step in files_for_e3sm needs to find the output in the corresponding remap_ice_shelf_melt in the init test case during setup() because that step no longer exists at construction.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

Following MPAS-Dev#813, the
initial state is the same whether ice shelf cavities are present
or not.  It is the result of the `init/initial_state` step
@xylar xylar added bug Something isn't working ocean labels Jul 1, 2024
@xylar xylar self-assigned this Jul 1, 2024
Since the step in the init test case doesn't exist at construciton
of the associated step in files_for_e3sm, we need to add the link
to the output file during `setup()` instead.
@xylar xylar changed the title Fix initial state filename in files for E3SM Fix files for E3SM following reorg of init Jul 1, 2024
@xylar
Copy link
Collaborator Author

xylar commented Jul 1, 2024

Testing

I ran the IcoswISC240 mesh through files_for_e3sm on Chrysalis. With the 2 fixes in this branch, it completed successfully, whereas without them it did not.

/lcrc/group/e3sm/ac.xylar/compass_1.4/chrysalis/test_20240701/icoswisc240_fix_files_for_e3sm

@xylar xylar merged commit ad3647a into MPAS-Dev:main Jul 1, 2024
4 checks passed
@xylar xylar deleted the fix-files-for-e3sm branch July 1, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant