Add edge masks to default arguments of make_region_masks
landice framework function
#786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds
edge
region masks to the default options of themake_region_masks
function within the mesh module of the landice framework.The addition of
edge
masks for regions is needed the by the recent addition of SGH quantities to regional stats analysis member inMALI-Dev
(MALI-Dev/E3SM#105).Originally, we planned on adding
vertex
masks aswell, to forestall future problems. But after some experimentation with the antarctic/mesh_gen testcase, the additional masks slow down testcase execution considerably (~50%). As very few variables are defined on vertices, we've opted to leave them out of the defaults for now.Checklist
Testing
in this PR) any testing that was used to verify the changes