Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure ny is even in ISOMIP+ test cases #772

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Feb 9, 2024

This is needed to allow 4 km ISOMIP+ tests.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added the bug Something isn't working label Feb 9, 2024
@xylar xylar requested a review from irenavankova February 9, 2024 11:25
@xylar xylar self-assigned this Feb 9, 2024
@xylar
Copy link
Collaborator Author

xylar commented Feb 9, 2024

@irenavankova, can you see if this fixes the issue you were seeing at 4 km?

@xylar
Copy link
Collaborator Author

xylar commented Feb 9, 2024

Testing

I was able to run the z-star 4 km ISOMIP+ test case with this branch, where as @irenavankova saw the following error without these changes:

ocean/isomip_plus/planar/4km/z-star/Ocean0
compass calling: compass.ocean.tests.isomip_plus.isomip_plus_test.IsomipPlusTest.run()
  inherited from: compass.testcase.TestCase.run()
  in /lcrc/group/e3sm/ac.vankova/compass/code/test_sgr_V2/compass/testcase.py

compass calling: compass.run.serial._run_test()
  in /lcrc/group/e3sm/ac.vankova/compass/code/test_sgr_V2/compass/run/serial.py

Running steps: process_geom, planar_mesh, cull_mesh, initial_state, ssh_adjustment, performance
  * step: process_geom
  * step: planar_mesh
      Failed
Exception raised while running the steps of the test case
Traceback (most recent call last):
  File "/lcrc/group/e3sm/ac.vankova/compass/code/test_sgr_V2/compass/run/serial.py", line 320, in _log_and_run_test
    _run_test(test_case, available_resources)
  File "/lcrc/group/e3sm/ac.vankova/compass/code/test_sgr_V2/compass/run/serial.py", line 417, in _run_test
    _run_step(test_case, step, test_case.new_step_log_file,
  File "/lcrc/group/e3sm/ac.vankova/compass/code/test_sgr_V2/compass/run/serial.py", line 468, in _run_step
    step.run()
  File "/lcrc/group/e3sm/ac.vankova/compass/code/test_sgr_V2/compass/ocean/tests/isomip_plus/planar_mesh.py", line 55, in run
    ds_mesh = make_planar_hex_mesh(nx=nx + 2, ny=ny + 2, dc=dc,
  File "/lcrc/group/e3sm/ac.vankova/mambaforge/envs/test_sgr_V2/lib/python3.10/site-packages/mpas_tools/planar_hex.py", line 59, in make_planar_hex_mesh
    mesh = initial_setup(nx, ny, dc, nonperiodic_x, nonperiodic_y)
  File "/lcrc/group/e3sm/ac.vankova/mambaforge/envs/test_sgr_V2/lib/python3.10/site-packages/mpas_tools/planar_hex.py", line 88, in initial_setup
    raise ValueError('ny must be divisible by 2 for the grid\'s '
ValueError: ny must be divisible by 2 for the grid's periodicity to work properly.

@xylar
Copy link
Collaborator Author

xylar commented Feb 9, 2024

I was also able to create 1 and 0.5 km meshes (just as a sanity check).

Copy link
Collaborator

@irenavankova irenavankova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this fixes the 4 km problem for me.

@xylar
Copy link
Collaborator Author

xylar commented Feb 13, 2024

Great, thank you @irenavankova!

@xylar xylar merged commit 4130abc into MPAS-Dev:main Feb 13, 2024
4 checks passed
@xylar xylar deleted the fix-isomip-plus-ny branch February 13, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants