-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure ny is even in ISOMIP+ test cases #772
Conversation
@irenavankova, can you see if this fixes the issue you were seeing at 4 km? |
TestingI was able to run the z-star 4 km ISOMIP+ test case with this branch, where as @irenavankova saw the following error without these changes:
|
I was also able to create 1 and 0.5 km meshes (just as a sanity check). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this fixes the 4 km problem for me.
Great, thank you @irenavankova! |
This is needed to allow 4 km ISOMIP+ tests.
Checklist
Testing
in this PR) any testing that was used to verify the changes