Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated data interpolation for Antarctica mesh generation case #750
Updated data interpolation for Antarctica mesh generation case #750
Changes from all commits
62b7f78
a2f4a91
fdd2f50
97295a6
9df9606
12b90e8
082e2be
3f67daa
6b3b0fe
8270f19
b8649fa
008e4d1
489e0b1
8a8bb4a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step is really slow, so we should check for an existing scrip file before proceeding. It should also write to the compass working directory instead of to the data directory if it does create a new scrip file. I'd rather have the data directory untouched.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check if your compass env contains the changes to MPAS-Tools here? MPAS-Dev/MPAS-Tools#544
This step got like 100x faster after that change. I'm wondering if you'd be comfortable skipping the check for an existing file if this step only takes a minute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think I know the answer - the conda env version for this branch would not have the MPAS-Tools update in it, because those were made at the same time as this PR. But I believe that MPAS-Tools PR is part of the current compass env. So try redoing your test after merging this branch locally into main (or rebasing) and creating an updated compass env.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've modified to write the scrip file to the workdir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As with the BedMachine scrip file, let's check for an existing file in the data directory before writing a huge new one. And it should write any new file to the work directory, leaving the data directory untouched. If the scrip file exists in the data directory, let's just put a symlink to it in the work directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've modified to write the scrip file to the workdir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This interpolation is never performed! Needs another
check_call(args, logger=logger)