This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
Required changes for threaded vector reconstruction #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-petersen
approved these changes
Apr 6, 2017
There was a problem hiding this comment.
Tested on grizzly with gnu. Results are bfb on the nightly regression suite with previous. Note that this includes the test:
'Baroclinic Channel 10km - Thread Test': -o ocean -c baroclinic_channel -r 10km -t threads_test
That does a bfb comparison between:
OMP_NUM_THREADS = 1
OMP_NUM_THREADS = 2
so it does exercise the openMP when you compile with:
make gfortran CORE=ocean OPENMP=true
This was referenced Apr 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of a new threaded reconstruction routine in #1237, openMP directives surrounding calls to this routine in the ocean core needed to be removed for consistency.