-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Land ice mesh tools to python 3 #249
Conversation
@matthewhoffman, here are changes needed to make the land ice mesh tools compatible with python 3. This should give you a sense of some of the more basic changes that are typically required. Mostly about print formatting. A few of the formatting changes aren't strictly necessary but there's a strong preference for the |
I don't have a great way to test these. I made sure they pass the |
The intention is to revise these scripts before including them in the |
@xylar , thanks for putting this together - it looks like a lot of tedious work. I'll take a look and try the new versions out. |
@matthewhoffman, eh, not as much work as I was anticipating. I'm starting to learn that a lot of the difficulties between python 2 and 3 come when you use fancier features like dictionaries and parse config files and stuff like that that you really only do when putting packages together, not scripts. With scripts, it's almost entirely the print statements. |
Let me know if I should split |
64299cf
to
68749f4
Compare
68749f4
to
3035a37
Compare
@matthewhoffman, could you suggest a process I could use to test these myself? I would like to include them in #248, which I think @mark-petersen and I will work on getting merged this week. |
Add futures to make python 2 code act like python 3
3035a37
to
f00466a
Compare
@matthewhoffman, @mark-petersen and I want to merge #248 today if at all possible. This builds off of this PR. I think I want to take the small risk that I broke your scripts when I added python 3 support and just merge these changes unless you want to test them today. The alternative would be that I remove these scripts from the conda package. Which would you prefer? |
My two cents: Let's take the leap on these and clean up any loose ends afterwards. @xylar has taken all reasonable precautions to change over to python 3. |
@xylar , that sounds entirely reasonable to me. I apologize for my failing to give this the attention it deserves. |
Thanks @matthewhoffman. |
Make a few minor formatting changes to the land ice mesh tools so they work in python 3 as well as python 2.
I also include
mark_horns_for_culling.py
because I think this script might be used primarily by the land-ice model and because I'm pretty sure that @matthewhoffman is the author of all 5 scripts.