Change start index from 1 to 2 on activeTracerVerticalAdvectionTopFlux #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E3SM with this change passes It was failing that before, in the monthly time average calculation. |
|
@vanroekel could you give this a quick visual sanity check? |
vanroekel
approved these changes
Feb 26, 2019
mark-petersen
added a commit
that referenced
this pull request
Feb 26, 2019
Vertical index k=1 on activeTracerVerticalAdvectionTopFlux is the ocean surface, so is always zero. It was using some uninitialized values when using k=1, so start loop at k=2.
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Feb 27, 2019
) Update mpas-source submodule to pick up indexing fix This PR brings in a new mpas-source submodule that fixes an indexing issue on an array that was causing debug tests to fail in the online time-averaging mpas analysis. Vertical index k=1 on activeTracerVerticalAdvectionTopFlux is the ocean surface, so is always zero. It was using some uninitialized values when using k=1, so start loop at k=2. See [MPAS-Model PR #165](MPAS-Dev/MPAS-Model#165) Fixes #2768 [BFB]
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Feb 27, 2019
Update mpas-source submodule to pick up indexing fix This PR brings in a new mpas-source submodule that fixes an indexing issue on an array that was causing debug tests to fail in the online time-averaging mpas analysis. Vertical index k=1 on activeTracerVerticalAdvectionTopFlux is the ocean surface, so is always zero. It was using some uninitialized values when using k=1, so start loop at k=2. See [MPAS-Model PR #165](MPAS-Dev/MPAS-Model#165) Fixes #2768 [BFB]
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Feb 28, 2019
Update mpas-source submodule to pick up indexing fix This PR brings in a new mpas-source submodule that fixes an indexing issue on an array that was causing debug tests to fail in the online time-averaging mpas analysis. Vertical index k=1 on activeTracerVerticalAdvectionTopFlux is the ocean surface, so is always zero. It was using some uninitialized values when using k=1, so start loop at k=2. See [MPAS-Model PR #165](MPAS-Dev/MPAS-Model#165) Fixes #2768 [BFB]
mark-petersen
added a commit
that referenced
this pull request
Jul 12, 2019
Vertical index k=1 on activeTracerVerticalAdvectionTopFlux is the ocean surface, so is always zero. It was using some uninitialized values when using k=1, so start loop at k=2. PR #165 was originally into ocean/develop, I'm just repeating into e3sm/maint-1.0
ashwathsv
pushed a commit
to ashwathsv/MPAS-Model
that referenced
this pull request
Jul 21, 2020
Vertical index k=1 on activeTracerVerticalAdvectionTopFlux is the ocean surface, so is always zero. It was using some uninitialized values when using k=1, so start loop at k=2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vertical index k=1 on activeTracerVerticalAdvectionTopFlux is the ocean surface, so is always zero. It was using some uninitialized values when using k=1, so start loop at k=2.