Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mpas_dmpar_bcast_real4s routine for broadcasting real(kind=R4KIND) arrays #1207

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

mgduda
Copy link
Contributor

@mgduda mgduda commented Jul 9, 2024

This PR adds a new mpas_dmpar_bcast_real4s routine for broadcasting real(kind=R4KIND) arrays.

The mpas_dmpar_bcast_real4s routine mirrors the mpas_dmpar_bcast_reals routine, with the dummy array argument being of R4KIND rather than RKIND kind.

…) arrays

This commit adds a new routine to the dmpar module for broadcasing
real(kind=R4KIND) arrays.  The new mpas_dmpar_bcast_real4s routine mirrors the
mpas_dmpar_bcast_reals routine, with the dummy array argument being of R4KIND
rather than RKIND kind.
@mgduda
Copy link
Contributor Author

mgduda commented Jul 9, 2024

This PR targets the hotfix-v8.2.1 branch since the mpas_dmpar_bcast_real4s routine added in this PR is required by PR #1208.

Copy link
Contributor

@amstokely amstokely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good temporary solution for fixing the double precision compilation problem. However, I think we should come up with a more robust way to broadcast real arrays in the future, as this subroutine would not be supported in a generic interface.

@mgduda
Copy link
Contributor Author

mgduda commented Jul 10, 2024

I think this is a good temporary solution for fixing the double precision compilation problem. However, I think we should come up with a more robust way to broadcast real arrays in the future, as this subroutine would not be supported in a generic interface.

Just to clarify, the mpas_dmpar_bcast_real4s routine definitely can be used as a specific implementation of a generic interface. If we were to do so, as I think you're getting at, there would be issues in calling the generic interface with multi-dimensional arrays, but that's no fault of the mpas_dmpar_bcast_real4s routine.

@mgduda mgduda merged commit 01340f6 into MPAS-Dev:hotfix-v8.2.1 Jul 10, 2024
@mgduda mgduda deleted the framework/bcast_real4s branch July 10, 2024 18:08
mgduda added a commit that referenced this pull request Aug 7, 2024
This merge addresses several issues in the MPAS-Atmosphere model and in the MPAS
infrastructure. Specific changes in this merge include:

* Improved detection of an 'mpi_f08' module (PR #1202), as well as improved
  detection of netCDF and PnetCDF library paths (PR #1203), in the top-level
  Makefile.

* The addition of a missing dependency in the physics Makefile to correct
  parallel build issues (PR #1204).

* Fixes to the CMake build files used by MPAS-JEDI (PR #1205).

* Fixes to double-precision builds of MPAS-Atmosphere (PR #1207, PR #1208).

* Correction of the calculation of height AGL used in the computation of 1-km
  radar reflectivity fields (PR #1213).

* Correction of an issue that prevented the MYNN PBL scheme from being used
  without also using the Thompson aerosol-aware microphysics (PR #1215).

* Fixes to allow MPAS-Atmosphere to be built without physics (i.e., dynamics-
  only builds) (PR #1221).

* Various code cleanup and minor corrections (PR #1206, PR #1212, PR #1224,
  PR #1226).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants