bug fix for the Thompson parameterization of the cloud fraction #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…corrected the units of the variable dx_p from meters to kilometers (dx_p is used in the Thompson parameterization of the cloud fraction).
e758cc7 to
9e1e1b4
Compare
|
I approve the PR. |
mgduda
approved these changes
Mar 25, 2024
byoung-joo
added a commit
to JCSDA-internal/MPAS-Model
that referenced
this pull request
Apr 23, 2024
DESCRIPTION OF CHANGES: This bugfix is from MPAS-Dev#1153 , which fixes the unit of dx_p variable as kilometers. The Thompson cloud fraction scheme is only activated when setting config_radt_cld_scheme = 'cld_fraction_thompson' in the MPAS namelist. LIST OF MODIFIED FILES: src/core_atmosphere/physics/mpas_atmphys_driver_cloudiness.F
ibanos90
pushed a commit
to JCSDA-internal/MPAS-Model
that referenced
this pull request
May 10, 2024
DESCRIPTION OF CHANGES: This bugfix is from MPAS-Dev#1153 , which fixes the unit of dx_p variable as kilometers. The Thompson cloud fraction scheme is only activated when setting config_radt_cld_scheme = 'cld_fraction_thompson' in the MPAS namelist. LIST OF MODIFIED FILES: src/core_atmosphere/physics/mpas_atmphys_driver_cloudiness.F
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bug fix when calling the Thompson parameterization of the cloud fraction. This bug was first brought to our attention by Brett Wilt back in February 2022 but never corrected in subsequent bug fix releases.
The input to the Thompson scheme is expecting the grid scale to be in units of km, but in mpas_atmphys_driver_cloudiness.F source, dx_p is in units of meters. The unit of dx_p has been corrected to be kilometers.