Missing script referenced in COMPASS Ocean #220
Comments
|
@xylar, Thanks for bringing this up. I don't think the script is ready to be merged at the moment. (It has paths that are hard-coded etc.) My feeling is that we should probably remove the reference for now. It should never have made it in without having the tool merged. Sorry about that. |
|
Okay, no problem. I'll remove it as part of a bigger commit I'm working on. |
mark-petersen
added a commit
that referenced
this issue
May 10, 2019
…s' into ocean/develop A large number of updates to the COMPASS ocean API including: - using the geometric_features conda package (MPAS-Dev/geometric_features#102) - using the mpas_tools conda package (MPAS-Dev/MPAS-Tools#248) - updating the jigsaw_to_MPAS scripts to work as a python package and to support python 3 - update global_ocean scripts to python 3 and to use these new packages NOTE: This merge removes the capability to create the global meshes used in E3SM version 1, (2017-2018), where the base meshes were created with Doug Jacobsen’s tool. The global mesh creation remaining after this commit only uses the Jigsaw tool. In order to recreate meshes and initial conditions used in E3SM version 1, use repositories as of March 1, 2019: 1. MPAS-Model commit:42029f218175d893cf25e19a26d9b43382a44d54 2. MPAS-Tools commit:6d0fa3a24e879a1a5b6149d9fbfe80fa021489dc 3. geometric_features tag:E3SMv3grids 76709be closes #220 closes #213 closes #132 closes #166
matthewhoffman
pushed a commit
to matthewhoffman/MPAS-Model
that referenced
this issue
Jun 28, 2019
…n/develop This is needed to create a V3 mesh with COMPASS. It has a matching PR in MPAS-Tools. NON-BFB MATCH for ocean nightly regression suite for global (QU240) cases when tested against previous commit. The QU240 will have a different number of cells. In order for new scripts to work, this version of MPAS-Model must be run with this commit of MPAS-Tools or later: f825edf Merge PR MPAS-Dev#220 'ocean/remove_landlocked_cells' into master
ashwathsv
pushed a commit
to ashwathsv/MPAS-Model
that referenced
this issue
Jul 21, 2020
…n/develop This is needed to create a V3 mesh with COMPASS. It has a matching PR in MPAS-Tools. NON-BFB MATCH for ocean nightly regression suite for global (QU240) cases when tested against previous commit. The QU240 will have a different number of cells. In order for new scripts to work, this version of MPAS-Model must be run with this commit of MPAS-Tools or later: f825edf Merge PR MPAS-Dev#220 'ocean/remove_landlocked_cells' into master
ashwathsv
pushed a commit
to ashwathsv/MPAS-Model
that referenced
this issue
Jul 21, 2020
…esh_tools' into ocean/develop A large number of updates to the COMPASS ocean API including: - using the geometric_features conda package (MPAS-Dev/geometric_features#102) - using the mpas_tools conda package (MPAS-Dev/MPAS-Tools#248) - updating the jigsaw_to_MPAS scripts to work as a python package and to support python 3 - update global_ocean scripts to python 3 and to use these new packages NOTE: This merge removes the capability to create the global meshes used in E3SM version 1, (2017-2018), where the base meshes were created with Doug Jacobsen’s tool. The global mesh creation remaining after this commit only uses the Jigsaw tool. In order to recreate meshes and initial conditions used in E3SM version 1, use repositories as of March 1, 2019: 1. MPAS-Model commit:42029f218175d893cf25e19a26d9b43382a44d54 2. MPAS-Tools commit:6d0fa3a24e879a1a5b6149d9fbfe80fa021489dc 3. geometric_features tag:E3SMv3grids 76709be closes MPAS-Dev#220 closes MPAS-Dev#213 closes MPAS-Dev#132 closes MPAS-Dev#166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A script,
mesh_comparison.pyis referenced in COMPASS's newgloba_oceantest cases:https://github.com/MPAS-Dev/MPAS-Model/blob/ocean/develop/testing_and_setup/compass/ocean/global_ocean/config_files/config_mesh_metrics.xml#L7
This file is pointing to
MPAS-Tools/mesh_tools/mesh_comparison.py, but there doesn't seem to be any such file:https://github.com/MPAS-Dev/MPAS-Tools/tree/master/mesh_tools
A little sleuthing suggests it's here:
https://github.com/sbrus89/MPAS-Tools/blob/jigsaw_mesh_creation/mesh_tools/mesh_comparison.py
but hasn't been merged and I didn't see a PR.
@sbrus89, is the solution to add this tool? Or to remove reference to it from COMPASS for now?
The text was updated successfully, but these errors were encountered: