update(rhs, hcof, AdvancedInput): bug fixes for advanced variables #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jlarsen-usgs
commented
Feb 25, 2023
- update rhs and hcof to copy values to pointer instead of overwriting the pointer
- add a check for AdvancedInput variables that do not have pointer support in xmipy
…es for advanced inputs * update rhs and hcof to copy values to pointer instead of overwriting the pointer * add a check for AdvancedInput variables that do not have pointer support in xmipy
spaulins-usgs
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
@jlarsen-usgs, looks good. It is now working for me. My only recommendation is to include getting, changing, and setting hcof, rhs, and some advanced variables in the test cases for more complete test coverage.
Perhaps modflowapi tests could include the flopy plugin tests once the flopy plugins code is merged into flopy. The flopy plugin tests should add to the testing coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.