fix(prt): fix particle reporting #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reporting was incorrect for permanently unreleased and timed-out particles. Also update some development notes.
6 tasks
wpbonelli
added a commit
that referenced
this pull request
Feb 3, 2025
Use enums for particle status and event codes, following #2188. Also remove an unnecessary/incorrect termination condition left over from #2185 in the base MethodType%check() routine — stationary particles get terminated at the end of the simulation by the tracking loop with timeout status, previously status 5 (no exit face) was getting reported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reporting was incorrect for permanently unreleased particles. We want to report them once whenever they are to be released. #2177 fixed an issue where they were reported every time step, but the solution was incorrect, only reporting them if the release occurred in the first time step.
Also fix reporting for timed-out particles. The new status code 10 introduced by #2177 covers not only the simulation end but the particle reaching its stop time as well.
Update some comments and notes too.