Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csub): CSUB observations #2137

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

jdhughes-usgs
Copy link
Contributor

Checklist of items for pull request

  • Replaced section above with description of pull request
  • Closed issue Incorrect documentation of "theta" CSUB observation type #1447
  • Referenced issue or pull request #xxxx
  • Added new test or modified an existing test
  • Ran ruff on new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.
  • Formatted new and modified Fortran source files with fprettify
  • Updated develop.tex with a plain-language description of the bug fix, change, feature; required for changes that may affect users
  • Updated input and output guide
  • Removed checklist items not relevant to this pull request

For additional information see instructions for contributing and instructions for developing.

@jdhughes-usgs
Copy link
Contributor Author

@langevin-usgs This PR changes the behaviour of some of the CSUB observations but some of the observations that could be accumulated with boundnames do not make any sense (for example, effective stress, compaction, etc) except when interbeds that were in a vertical column used the same boundname. Seemed simpler to just eliminate the possibility that something nonsensical could be specified.

Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jdhughes-usgs jdhughes-usgs merged commit 0756f90 into MODFLOW-USGS:develop Jan 15, 2025
20 checks passed
@wpbonelli wpbonelli added this to the 6.6.1 milestone Jan 18, 2025
@wpbonelli wpbonelli added bug documentation Documentation changes labels Jan 18, 2025
@jdhughes-usgs jdhughes-usgs deleted the fix-1447-redo branch January 27, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug documentation Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect documentation of "theta" CSUB observation type
3 participants