Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tsp-apt): remove gwe-specific code from apt and distribute to advanced gwe packages #2123

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

emorway-usgs
Copy link
Contributor

The variables ktf, thermal conductivity of the of the interface between the aquifer cell and the apt feature, for example a stream reach, and rfeatthk, a real value that defines the thickness of the streambed material through which conduction occurs, are specific to GWE and shouldn't have been added to APT in the first place. This PR removes both variables from APT and distributes them to SFE, LKE, and MWE where they are needed. Three pre-existing GWE autotests were already in place to help ensure that the changes didn't break anything (test_gwe_sfe_strmbedcond.py, test_gwe_lke_conduction.py, and test_gwe_mwe_conduction.py).

Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work getting these variables out of the tsp model. Perhaps at some point we can come up with a way to remove all this duplicate code, but for now I think this is good. I had one comment about the term "interface". Wonder if we need a better term for this as there should be a thickness to this interface that we might want to mention somewhere.

doc/mf6io/mf6ivar/dfn/gwe-lke.dfn Outdated Show resolved Hide resolved
emorway-usgs added a commit to emorway-usgs/modflow6 that referenced this pull request Jan 2, 2025
@langevin-usgs langevin-usgs merged commit 2a063b9 into MODFLOW-USGS:develop Jan 3, 2025
20 checks passed
@emorway-usgs emorway-usgs deleted the refact_apt branch January 3, 2025 16:27
@wpbonelli wpbonelli added this to the 6.6.1 milestone Jan 6, 2025
@wpbonelli wpbonelli added the code refactor Nonfunctional changes label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code refactor Nonfunctional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants