refactor(gwe-est): remove packagedata block and put values in options block #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ae672d to
f585116
Compare
There was a problem hiding this comment.
Thanks for doing this. I think this is a cleaner implementation. My only comment would be to consider renaming the keywords to HEAT_CAPACITY_WATER and DENSITY_WATER. You can leave the internal fortran variables the same (by setting mf6internal in the definition file entries).
emorway-usgs
added a commit
to emorway-usgs/modflow6
that referenced
this pull request
Jun 19, 2024
I'm fine with this change, I considered longer names to begin with but opted for the shorter names initially. Thanks for the suggestion. |
There was a problem hiding this comment.
Hey @emorway-usgs, just a few more comments to think about.
emorway-usgs
added a commit
to emorway-usgs/modflow6
that referenced
this pull request
Jun 20, 2024
emorway-usgs
added a commit
to emorway-usgs/modflow6
that referenced
this pull request
Jun 20, 2024
langevin-usgs
approved these changes
Jun 21, 2024
Co-authored-by: langevin-usgs <langevin@usgs.gov>
1476118 to
b629d58
Compare
emorway-usgs
added a commit
to MODFLOW-USGS/modflow6-examples
that referenced
this pull request
Jun 21, 2024
…ock (#212) updating calls to `flopy.mf6.ModflowGweest()` to reflect the recent changes to the input structure of the Energy Storage and Transfer (EST) package. See #1882 on the main MODFLOW 6 repo (MODFLOW-USGS/modflow6#1882)
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blackon new or modified autotestsfprettifyFor additional information see instructions for contributing and instructions for developing.