-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(netcdf): support model ugrid layered mesh exports #1868
Conversation
c8db1ff
to
299d898
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One minor comment about testing, but think it can be handled later.
@@ -0,0 +1,568 @@ | |||
""" | |||
Test problem for GWE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this model is the same as test_gwe_cnd, is it possible to just import build_models, etc. from the test_gwe_cnd python source file? I think that's how some of the parallel tests are constructed. Would need some way to inject the export_array_netcdf=True into the relevant packages. Just a suggestion as a way to remove duplication. Comment applies to the other tests as well, but maybe best left for a subsequent PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree something along those lines would be a better approach to eliminate the redundancy and improve maintainability. I'll plan to make these updates soon.
EXPORT_NETCDF UGRID
name file optionEXPORT_ARRAY_NETCDF
NCF6
package withOGC_WKT
optionNCF6
options:DEFLATE <integer>
(per variable compression 0-9)SHUFFLE
keyword (variable byte shuffling which can improve compression)DEFLATE
option providedCHUNKING_UGRID
record (per variable time and face dimension chunk sizes)