Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dfn): mark transient blocks #178

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

wpbonelli
Copy link
Contributor

The iper variable was previously missed. It has in_record true but it's not in a record, as per mf6's definition, it's in the period block. I suppose in_record really means "is a child of a composite", which is in tension with the hard distinction mf6 makes between blocks and variables. In the TOML format we no longer need in_record.

IMO it's cleaner to just mark transient blocks as such instead of defining an extra iper index variable. This does mean that we will need to translate the transient flag back into "iper" terminology for the mf6io guide, e.g. for examples like

BEGIN PERIOD <iper>
  [SAVE <rtype> <ocsetting>]
  [PRINT <rtype> <ocsetting>]
END PERIOD

@wpbonelli wpbonelli merged commit 50cba8b into MODFLOW-USGS:develop Jan 26, 2025
18 checks passed
@wpbonelli wpbonelli deleted the dfn branch January 26, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant