Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
iper
variable was previously missed. It hasin_record true
but it's not in a record, as per mf6's definition, it's in theperiod
block. I supposein_record
really means "is a child of a composite", which is in tension with the hard distinction mf6 makes between blocks and variables. In the TOML format we no longer needin_record
.IMO it's cleaner to just mark transient blocks as such instead of defining an extra
iper
index variable. This does mean that we will need to translate the transient flag back into "iper" terminology for the mf6io guide, e.g. for examples like