refactor(has_pkg): introduce strict flag #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9adf9f3 to
c917bce
Compare
* add strict param to has_pkg() toggling whether to try to import the pkg or only check metadata * always invalidate/refresh the cache if strict is on * add pytest-virtualenv to test dependencies, test with/without strict * use --dist loadfile with xdist in CI for compatibility * use strict=True for requires_pkg marker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strictparam tohas_pkg()toggling whether to try to import the pkg or only check metadatapytest-virtualenvto test dependencies, test with/without strict--dist loadfilewith xdist in CI for compatibilityrequires_pkgcould fail if a pkg has been installed but is missing dependencies