Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(idm): allow filein tags in mfsim.nam options block #1770

Merged
merged 4 commits into from
May 6, 2024

Conversation

mjreno
Copy link
Contributor

@mjreno mjreno commented May 3, 2024

This PR addresses the error below. This issue can be seen following #1763 which adds a FILEIN style tag to the mfsim.nam options block in support of parallel.

ERROR REPORT:

  1. IdmLoad allocate simnam param unhandled datatype: RECORD HPC6 FILEIN
     HPC6_FILENAME

UNIT ERROR REPORT:

  1. ERROR OCCURRED WHILE READING FILE 'mfsim.nam'

@mjreno mjreno assigned mjreno and mjr-deltares and unassigned mjreno May 3, 2024
@jdhughes-dev
Copy link
Contributor

jdhughes-dev commented May 4, 2024

@mjreno The failures with test019_VilhelmsenLGR and test019_VilhelmsenLGR_nr seem to be related to recent dfn and/or idm changes. These tests are reading idomain for the parent in as a 3D array. The model is a multi-layer model.

I can get the tests to pass locally with the idm source files on develop. The tests do not pass if I regenerate idm files from the dfns in the repo. I get a different error related to the HPC file.

Not sure what is going on but it is affecting all of PRs.

@mjreno
Copy link
Contributor Author

mjreno commented May 4, 2024

Thanks @jdhughes-usgs I'll check it out.

@christianlangevin
Copy link

Yeah, I'm seeing the same thing locally. I pulled all the latest, and my tests are failing with

ERROR REPORT:

  1. IdmLoad allocate simnam param unhandled datatype: RECORD HPC6 FILEIN
     HPC6_FILENAME

UNIT ERROR REPORT:

  1. ERROR OCCURRED WHILE READING FILE 'mfsim.nam'

@mjreno
Copy link
Contributor Author

mjreno commented May 4, 2024

@langevin-usgs @jdhughes-usgs that error should be addressed with this PR. The test019_VilhelmsenLGR failures are FloPy errors that are happening when it is loading test model input and seem unrelated.

@christianlangevin
Copy link

Do we need to accept this failing PR and then address the idomain loading failure?

@mjreno
Copy link
Contributor Author

mjreno commented May 4, 2024

If the FloPy issue is unrelated it seems like it could be addressed and then most of these tests should pass- is the Build ReadTheDocs failure related?

However it might make sense to merge this PR sooner than that to get people unblocked locally.

@wpbonelli
Copy link
Contributor

@mjreno the RTD failure was my fault, it has since been fixed in the mf6 examples repo

@christianlangevin
Copy link

It seems there is still some sort of error with a flopy idomain load. I haven't been able to track it down yet.

@wpbonelli
Copy link
Contributor

I think that is the same issue as here, @spaulins-usgs and I spoke briefly Friday, it is related to the change in flopy's array reading behavior introduced with modflowpy/flopy#2053, but we did not come to a resolution

@christianlangevin
Copy link

This is passing now. Will merge.

@christianlangevin christianlangevin merged commit df31dcf into MODFLOW-ORG:develop May 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants