-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(idm): allow filein tags in mfsim.nam options block #1770
Conversation
@mjreno The failures with test019_VilhelmsenLGR and test019_VilhelmsenLGR_nr seem to be related to recent dfn and/or idm changes. These tests are reading idomain for the parent in as a 3D array. The model is a multi-layer model. I can get the tests to pass locally with the idm source files on develop. The tests do not pass if I regenerate idm files from the dfns in the repo. I get a different error related to the HPC file. Not sure what is going on but it is affecting all of PRs. |
Thanks @jdhughes-usgs I'll check it out. |
Yeah, I'm seeing the same thing locally. I pulled all the latest, and my tests are failing with
|
@langevin-usgs @jdhughes-usgs that error should be addressed with this PR. The test019_VilhelmsenLGR failures are FloPy errors that are happening when it is loading test model input and seem unrelated. |
Do we need to accept this failing PR and then address the idomain loading failure? |
If the FloPy issue is unrelated it seems like it could be addressed and then most of these tests should pass- is the Build ReadTheDocs failure related? However it might make sense to merge this PR sooner than that to get people unblocked locally. |
@mjreno the RTD failure was my fault, it has since been fixed in the mf6 examples repo |
It seems there is still some sort of error with a flopy idomain load. I haven't been able to track it down yet. |
I think that is the same issue as here, @spaulins-usgs and I spoke briefly Friday, it is related to the change in flopy's array reading behavior introduced with modflowpy/flopy#2053, but we did not come to a resolution |
This is passing now. Will merge. |
This PR addresses the error below. This issue can be seen following #1763 which adds a FILEIN style tag to the mfsim.nam options block in support of parallel.