update dependencies #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: * adding .idea to .gitignore for Pycharm IDE project dir (similar to .vscode) * updating dependencies * click updated from 8.1.3 to 8.1.4; changed order of decorators to address mypy linting error
cb72994 to
4fe1236
Compare
ehanson8
approved these changes
Jul 11, 2023
|
After work was completed and some more digging, found this issue with While the reordering of the decorators does pass |
ghukill
added a commit
that referenced
this pull request
Jul 18, 2023
Why these changes are being introduced: * In PR #91, while updating dependencies, `click` and `mypy` had a conflict. * A temporary workaround was put into place that reordered the `click` decorators, but this deviated from other projects. * Now that `click` has updated again, that workaround is no longer needed. How this addresses that need: * Reverting the order of `click` decorators re-aligns with other projects. * Dependencies are updated. Side effects of this change: * None Relevant ticket(s): * None
ghukill
added a commit
that referenced
this pull request
Jul 18, 2023
* Update type hints in helpers.write_timdex_records_to_json Why these changes are being introduced: * After some refactoring in 07/2022 that added an iterator pattern to Transformer, it looks as though downstream type hints were not updated. * While this did not affect runtime, it made reading the code somewhat confusing to someone new to the codebase. How this addresses that need: * Update the `records` input argument of `helpers.write_timdex_records_to_json()` from `Iterator[TimdexRecord]` to `Transformer` * rename `records` to `transformer_instance`, matching variable names from calling `cli.py` * Add explicit `TimdexRecord` type hint for result of `next(transformer_instance)` Side effects of this change: * None Relevant ticket(s): * None Additional maintenance: * Updated syntax for isort command in Makefile * Based on new results from isort, update import order in helpers.py * update dependencies and revert click workaround * In PR #91, while updating dependencies, `click` and `mypy` had a conflict. * A temporary workaround was put into place that reordered the `click` decorators, but this deviated from other projects. * Now that `click` has updated again, that workaround is no longer needed. * Resolves #92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful background context
.ideato.gitignorefor Pycharm IDE project dir (similar to.vscode)clickupdated from 8.1.3 to 8.1.4; changed order of decorators to address mypy linting errorHow can a reviewer manually see the effects of these changes?
Tested that changing
clickdecorator order doesn't affect invoking:Developer
Code Reviewer
(not just this pull request message)
Includes new or updated dependencies?
YES