Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMX400 - new POPUPVINYL holdings location #209

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

ghukill
Copy link
Contributor

@ghukill ghukill commented Nov 15, 2024

Purpose and background context

Adds new physical holdings location POPUPVINYL / "Pop-Up Vinyl Collection".

How can a reviewer manually see the effects of these changes?

To my knowledge, we don't have any records with this location yet, but confirmed it'll follow the same tag + subfield combination for other locations we crosswalk, so should get picked up and used when those records start coming through.

Includes new or updated dependencies?

NO

Changes expectations for external applications?

NO

What are the relevant tickets?

Developer

  • All new ENV is documented in README
  • All new ENV has been added to staging and production environments
  • All related Jira tickets are linked in commit message(s)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

  • The commit message is clear and follows our guidelines (not just this PR message)
  • There are appropriate tests covering any new functionality
  • The provided documentation is sufficient for understanding any new functionality introduced
  • Any manual tests have been performed and verified
  • New dependencies are appropriate or there were no changes

How this addresses that need:
* Update holdings location crosswalk to handle new POPUPVINYL
location

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/TIMX-400
@ghukill ghukill merged commit 65dab54 into main Nov 18, 2024
4 checks passed
@ehanson8 ehanson8 deleted the TIMX-400-new-popupvinyl-location branch November 25, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants