Maintenance updates #207
Merged
Maintenance updates #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: * Routine maintenance updates How this addresses that need: * Upgrade to Python 3.12 Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IN-1079
ghukill
approved these changes
Oct 29, 2024
ehanson8
approved these changes
Oct 29, 2024
| JSON: TypeAlias = dict[str, "JSON"] | list["JSON"] | str | int | float | bool | None | ||
| type JSON = dict[str, "JSON"] | list["JSON"] | str | int | float | bool | None |
There was a problem hiding this comment.
Interesting change, thanks for highlighting the ruff rule!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Update app according to DataEng Application Maintenance. Main updates were to:
How can a reviewer manually see the effects of these changes?
Run
make lintandmake testand confirm linters and unit tests are all passing.Note: Publishing a release is on hold until we can test our full set of changes (field method refactor + orchestration refactor + these maintenance updates) with Transmogrifier A/B Diff.
Includes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)