Timx 288 marc field method refactor 5 #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghukill
approved these changes
Aug 1, 2024
ehanson8
approved these changes
Aug 1, 2024
transmogrifier/sources/xml/marc.py
Outdated
Comment on lines
629
to
567
| xml_element=datafield, | ||
| subfield_codes=identifier_marc_field["subfields"], | ||
| separator=". ", |
There was a problem hiding this comment.
Again, great choice to use named args!
6da2f04 to
353bf34
Compare
Why these changes are being introduced: * These updates are required to implement the architecture described in the following ADR: https://github.com/MITLibraries/transmogrifier/blob/main/docs/adrs/0005-field-methods.md How this addresses that need: * Clean up docstrings for utility methods * Rename xml -> source_record in abstract methods * Use kwargs when >3 parameters * Use tuples to define MARC field mappings Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-288
353bf34 to
bbf688d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Field method refactor for transform class Marc (Part 5).
This PR concludes the field method refactor updates for Marc. The changes introduced this PR are minor, tidying changes meant to improve code readability. Of note is the replacing the use of dictionaries when defining MARC field mappings with tuples, allowing us to assign helpful variable names to the tuple values in the
for loop.How can a reviewer manually see the effects of these changes?
Run
make testand verify all unit tests are passing.Run CLI command
Output:
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
https://mitlibraries.atlassian.net/browse/TIMX-288
Developer
Code Reviewer(s)