TIMX-234 Update aspace identifiers logic #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For ASpace records, any
<unitid type="aspace_uri">
elements are skipped for consideration as TIMDEX recordidentifiers
.Helpful background context
It was discovered that some ASpace records after transformation contained multiple identifiers, of the same type, which was throwing errors in Bento. It looks as though ASpace records may have changed slightly and are exposing a new string for the element, which is the same as the OAI record identifier.
Before:
![Screenshot 2023-08-16 at 11 06 56 AM](https://private-user-images.githubusercontent.com/1753087/261069546-cec8d858-1968-40be-a6fb-c70db9f6ea25.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMDk4NTIsIm5iZiI6MTczOTMwOTU1MiwicGF0aCI6Ii8xNzUzMDg3LzI2MTA2OTU0Ni1jZWM4ZDg1OC0xOTY4LTQwYmUtYTZmYi1jNzBkYjlmNmVhMjUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMjEzMjMyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjYyMWNlOWJiZGY4MGI3YWI2NWE1Y2UyZjlkZWY1MGQ5NTA1MjY3YTU4MzJkYzBhMjIzYTcwYTAzN2UxMmNmNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.-t2wmueA-cgqE9R6NdN3U2p7ifX6YYOtC1gy4ZtMv5c)
After:
![Screenshot 2023-08-16 at 11 05 54 AM](https://private-user-images.githubusercontent.com/1753087/261069574-5ce78c17-8e88-4ef7-8bd0-2f1c12bc83af.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMDk4NTIsIm5iZiI6MTczOTMwOTU1MiwicGF0aCI6Ii8xNzUzMDg3LzI2MTA2OTU3NC01Y2U3OGMxNy04ZTg4LTRlZjctOGJkMC0yZjFjMTJiYzgzYWYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMjEzMjMyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZGY3Y2Y3ODY2OTJjZTE3NmQyYjM1YTZlMDFkYzViNTdmYjAyMDM1N2Q4NjY2ZTlhZTgxYTU4YTVlMjI2NWFiNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.Eul53pg_FljhEGHTTfE0evIbZ8toUkZbUBLDTOGwgIc)
How can a reviewer manually see the effects of these changes?
Run the following transform:
identifiers
property only has a single value, despite two<unitid>
elements present under<archdesc level="collection">
What are the relevant tickets?
https://mitlibraries.atlassian.net/browse/TIMX-234
Developer
Code Reviewer
(not just this pull request message)
Includes new or updated dependencies?
YES