Further updates based on discussion in PR #175

* Shift param order for SkippedRecordEvent
MITLibraries · May 17, 2024 · 2d179ab · 2d179ab
1 parent 078291d
commit 2d179ab
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/transmogrifier/exceptions.py b/transmogrifier/exceptions.py
@@ -16,6 +16,6 @@ class SkippedRecordEvent(Exception):  # noqa: N818
         source_record_id: The ID for the source record.
     """
 
-    def __init__(self, source_record_id: str | None, message: str) -> None:
+    def __init__(self, message: str | None = None, source_record_id: str | None = None):
+        super().__init__(message)
         self.source_record_id = source_record_id
-        self.message = message
diff --git a/transmogrifier/sources/xml/datacite.py b/transmogrifier/sources/xml/datacite.py
@@ -56,7 +56,7 @@ def get_optional_fields(self, xml: Tag) -> dict | None:
                     fields["content_type"] = [content_type]
                 else:
                     message = f'Record skipped based on content type: "{content_type}"'
-                    raise SkippedRecordEvent(source_record_id, message)
+                    raise SkippedRecordEvent(message, source_record_id)
         else:
             logger.warning(
                 "Datacite record %s missing required Datacite field resourceType",